[
https://issues.apache.org/jira/browse/LUCENE-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eks Dev updated LUCENE-1219:
----------------------------
Attachment: LUCENE-1219.patch
all tests pass with this patch.
some polish needed and probably more testing, TODOs:
- someone pedantic should check if these new set / get methods should be named
better
- check if there are more places where this new feature cold/should be used, I
think I have changed all of them but one place, direct subclass FieldForMerge
in FieldsReader, this is the code I do not know so I did not touch it...
- javadoc is poor
should be enough to get us started.
the only "pseudo-issue" I see is that
public byte[] binaryValue(); now creates byte[] and copies content into it,
reference to original array can be now fetched via getBinaryValue() method...
this is to preserve compatibility as users expect compact, zero based array
from this method and we keep offset/length in Field now
this is "pseudo issue" as users already should have a reference to this array,
so this method is rather superfluous for end users.
> support array/offset/ length setters for Field with binary data
> ---------------------------------------------------------------
>
> Key: LUCENE-1219
> URL: https://issues.apache.org/jira/browse/LUCENE-1219
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Eks Dev
> Priority: Minor
> Attachments: LUCENE-1219.patch
>
>
> currently Field/Fieldable interface supports only compact, zero based byte
> arrays. This forces end users to create and copy content of new objects
> before passing them to Lucene as such fields are often of variable size.
> Depending on use case, this can bring far from negligible performance
> improvement.
> this approach extends Fieldable interface with 3 new methods
> getOffset(); gettLenght(); and getBinaryValue() (this only returns reference
> to the array)
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
