Nicolas Lalevée wrote:
Le lundi 17 mars 2008, Michael McCandless a écrit :
The javadocs used to say "this method returns null when there are no
matching fields". I removed that. Maybe I should add back in "this
method returns an empty array when there are no matching fields"?
In fact there were some "This method can return null" [1] which
were quite
evasive. Yes a comment like the following one will be great:
"this method returns an empty array when there are no matching
fields. It
never returns <code>null</code>"
OK will do.
Note also that in your commit you didn't fixed every javadoc :
* Returns an array of byte arrays for of the fields that have
the name
specified
- * as the method parameter. This method will return <code>null</
code> if no
- * binary fields with the specified name are available.
+ * as the method parameter.
*
* @param name the name of the field
* @return a <code>byte[][]</code> of binary field values or
<code>null</code>
@@ -281,7 +281,7 @@
}
Woops, missed that. I'll fix it too. Thanks!
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
