[
https://issues.apache.org/jira/browse/LUCENE-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580831#action_12580831
]
Michael McCandless commented on LUCENE-510:
-------------------------------------------
{quote}
IMHO, the char 0xffff is not telling that the string is the end. The marker is
not to be used to dermine the termination, but is for assertion, I think (in
DocumentsWriterThreadState.java).
{quote}
The 0xffff is used for more than assertion. It marks the end of the text for
each term.
{quote}
And we should rewrite DocumentsWriterFieldMergeState.java to provide "private
int postingUpto" outside via public method, to use it in DocumentsWriter.java
and DocumentsWriterField.java.
{quote}
The "private int postingUpto" in DocumentsWriterFieldMergeState is very
different from the usage of 0xffff marker; I'm not sure what you're suggesting
here?
> IndexOutput.writeString() should write length in bytes
> ------------------------------------------------------
>
> Key: LUCENE-510
> URL: https://issues.apache.org/jira/browse/LUCENE-510
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Store
> Affects Versions: 2.1
> Reporter: Doug Cutting
> Assignee: Michael McCandless
> Attachments: LUCENE-510.patch, LUCENE-510.take2.patch,
> SortExternal.java, strings.diff, TestSortExternal.java
>
>
> We should change the format of strings written to indexes so that the length
> of the string is in bytes, not Java characters. This issue has been
> discussed at:
> http://www.mail-archive.com/java-dev@lucene.apache.org/msg01970.html
> We must increment the file format number to indicate this change. At least
> the format number in the segments file should change.
> I'm targetting this for 2.1, i.e., we shouldn't commit it to trunk until
> after 2.0 is released, to minimize incompatible changes between 1.9 and 2.0
> (other than removal of deprecated features).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
