[ https://issues.apache.org/jira/browse/LUCENE-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581860#action_12581860 ]
Hiroaki Kawai commented on LUCENE-1241: --------------------------------------- {quote} This looks neat, but, can you pull this all together into a single workable patch that we can run some performance tests on? {quote} OK, I can. But, do you really want a huge single patch? And, this is yet another issue to do. I want to do the right thing, and performance is also yet another issue. > 0xffff char is not a string terminator > -------------------------------------- > > Key: LUCENE-1241 > URL: https://issues.apache.org/jira/browse/LUCENE-1241 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Reporter: Hiroaki Kawai > Attachments: ComparableCharSequence.java, LUCENE-1241.patch > > > Current trunk index.DocumentWriter uses "\uffff" as a string terminator, but > it should not to be for some reasons. \uffff is not a terminator char itself > and we can't handle a string that really contains \uffff. And also, we can > calculate the end char position in a character sequence from the string > length that we already know. > However, I agree with the usage for assertion, that "\uffff" is placed after > at the end of a string in a char sequence. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]