index reopen question

[John Wang]

Hi:
    Have been reading the 2.3.1 release code and have a few questions
regarding indexReader reopen:

1)  looking at the code:

    if (this.hasChanges || this.isCurrent()) {

      // the index hasn't changed - nothing to do here

      return this;

    }


   Shouldn't it be !this.hasChanges?


2) FilterIndexReader calls the ensureOpen() method from the super class
instead of overriding the method and call the inner reader's ensureOpen, is
that expected?


3) When you reopen an index, the inner reference count is not updated, is
that ok?


Thanks


-John