[
https://issues.apache.org/jira/browse/LUCENE-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593177#action_12593177
]
Mark Miller commented on LUCENE-794:
------------------------------------
Darn...waited just too long to comment on this. I had noticed two tiny things:
there is a System.out if a query is not recognized by the Query to Span
converter. Also, the get weightedTerms call might want to accept a
cachingtokenfilter rather than a tokenstream...I don't think this is a biggie
though...just avoids double wrapping in a cachingtokenfilter if that is what is
passed in. Someone mentioned that one on the list a few days ago. Neither
issues are a big deal, but would be nice to get the System.out out of
there...sorry I missed it in the patch.
Also,
Sorry about the bad build file Hoss :( I swear I copied it off another contrib
(I didn't know how to do it frankly), so I can't explain why its so incorrect.
Maybe I have accumulated too much of this beer I keep demanding and dont
remember changing things for the worse...
> Extend contrib Highlighter to properly support PhraseQuery, SpanQuery,
> ConstantScoreRangeQuery
> -----------------------------------------------------------------------------------------------
>
> Key: LUCENE-794
> URL: https://issues.apache.org/jira/browse/LUCENE-794
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Other
> Reporter: Mark Miller
> Priority: Minor
> Fix For: 2.3.2
>
> Attachments: MultiPhraseQueryExtraction.patch,
> SpanHighlighter-01-26-2008.patch, SpanHighlighter-01-28-2008.patch,
> SpanHighlighter-02-10-2008.patch, spanhighlighter.patch,
> spanhighlighter10.patch, spanhighlighter11.patch, spanhighlighter12.patch,
> spanhighlighter2.patch, spanhighlighter3.patch, spanhighlighter5.patch,
> spanhighlighter6.patch, spanhighlighter7.patch, spanhighlighter8.patch,
> spanhighlighter9.patch, spanhighlighter_24_January_2008.patch,
> spanhighlighter_patch_4.zip
>
>
> This patch adds a new Scorer class (SpanQueryScorer) to the Highlighter
> package that scores just like QueryScorer, but scores a 0 for Terms that did
> not cause the Query hit. This gives 'actual' hit highlighting for the range
> of SpanQuerys, PhraseQuery, and ConstantScoreRangeQuery. New Query types are
> easy to add. There is also a new Fragmenter that attempts to fragment without
> breaking up Spans.
> See http://issues.apache.org/jira/browse/LUCENE-403 for some background.
> There is a dependency on MemoryIndex.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
