Michael McCandless wrote:
But, in TokenFilter, next() should be deprecated, IMHO.
I think this is a good idea. After all if people don't want to bother
using the passed in Token, they are still allowed to return a new
one.
I'm looking into the deprecation of TokenStream.next(). I have come
across a pattern that wants to know if there are future tokens:
Token t1 = tokenStream.next();
Token t2 = tokenStream.next();
if (t2 != null) {
// there are multiple tokens
... setup for multiple token scenario ...
... consume t1, t2 and then loop ...
} else {
// there is only one token
... setup for single token scenario ...
... consume t1 ...
}
I'm wondering as to the best way to handle this. An obvious solution
come to mind: use clone()
Token token = new Token();
Token t1 = tokenStream.next(token);
if (t1 != null) {
t1 = t1.clone();
}
Token t2 = tokenStream.next(token);
... same as before, but calling tokenStream.next(token) ...
Another is to use tokenStream.reset(), but I am not sure that all
tokenStreams correctly implement it or that it is performant.
All the other solutions I can think of cause more grief to existing code.
-- DM
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
