Thanks. I created issue https://issues.apache.org/jira/browse/LUCENE-1356and submitted a patch. Do you think it can be included in 2.3.3?
On Wed, Aug 13, 2008 at 4:44 PM, Doron Cohen <[EMAIL PROTECTED]> wrote: > Sounds logical to me. After all, TopDocCollector already has a subclass >> (TopFieldDocCollector), and it is quite natural that users might want to >> add more - to implement different sorting mechanisms (e.g., according >> to payloads, database data, or whatever). >> >> Does anyone disagree? Is there a reason why this change should not be >> done? >> > > I didn't find any reason not to do this. > One way to bypass this is to create your collector in the same package, > though I can see this is not always convenient. > Out of curiosity I looked for other place in the code where a data member > is declared protected. > spanFilter in CachingSpanFilter is an example for one. > > > I do not see any issue with this, so if you agree, I'll open a JIRA >> issue and post a patch. >> > > Please do. > > Doron >