[ 
https://issues.apache.org/jira/browse/LUCENE-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-1335:
---------------------------------------

    Attachment: LUCENE-1335.patch

OK new patch attached with changes discussed above.

I did fix CMS to happily perform merges involving external segments
with its BG threads.  The hang I was seeing before was because as each
BG thread hit the disk-full exception (in the test), it would abort
that thread, and eventually no threads were doing merges even though
merges were still pending.  So copyExternalSegments would then
wait forever.

The fix was simple: I changed resolveExternalSegments (renamed from
copyExternalSegments) to pick up any pending merges that involve
external segments and run the merge itself, only falling back to the
"wait" call when all such merges were already in progress in CMS.
This way the disk full error is hit in the FG and the transaction (in
addIndexesNoOptimize) unwinds.


> Correctly handle concurrent calls to addIndexes, optimize, commit
> -----------------------------------------------------------------
>
>                 Key: LUCENE-1335
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1335
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 2.3, 2.3.1
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.4
>
>         Attachments: LUCENE-1335.patch, LUCENE-1335.patch, LUCENE-1335.patch, 
> LUCENE-1335.patch, LUCENE-1335.patch
>
>
> Spinoff from here:
>     
> http://mail-archives.apache.org/mod_mbox/lucene-java-dev/200807.mbox/[EMAIL 
> PROTECTED]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to