SimpleSpanFragmenter can create very short fragments
----------------------------------------------------

                 Key: LUCENE-1389
                 URL: https://issues.apache.org/jira/browse/LUCENE-1389
             Project: Lucene - Java
          Issue Type: Bug
          Components: contrib/highlighter
    Affects Versions: 2.3.2
            Reporter: Andrew Duffy
            Priority: Minor


Line 74 of SimpleSpanFragmenter returns true when the current token is the 
start of a hit on a span or phrase, thus starting a new fragment. Two problems 
occur:

- The previous fragment may be very short, but if it contains a hit it will be 
combined with the new fragment later so this disappears.
- If the token is close to a natural fragment boundary the new fragment will 
end up very short; possibly even as short as just the span or phrase itself. 
This is the result of creating a new fragment without incrementing 
currentNumFrags.

To fix, remove or comment out line 74. The result is that fragments average to 
the fragment size unless a span or phrase hit is towards the end of the 
fragment - that fragment is made larger and the following fragment shorter to 
accommodate the hit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to