[ https://issues.apache.org/jira/browse/LUCENE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12646005#action_12646005 ]
Michael McCandless commented on LUCENE-1424: -------------------------------------------- I'm having trouble applying the latest patch -- I get failed Hunks, and, patch can't find one of the source files: {code} patching file contrib/highlighter/src/test/org/apache/lucene/search/highlight/HighlighterTest.java patching file src/java/org/apache/lucene/queryParser/QueryParser.java patching file src/java/org/apache/lucene/search/ConstantScoreRangeQuery.java Hunk #2 FAILED at 29. 1 out of 2 hunks FAILED -- saving rejects to file src/java/org/apache/lucene/search/ConstantScoreRangeQuery.java.rej patching file src/java/org/apache/lucene/search/MultiTermQuery.java patching file src/java/org/apache/lucene/search/PrefixFilter.java patching file src/java/org/apache/lucene/search/PrefixQuery.java patching file src/java/org/apache/lucene/search/PrefixTermEnum.java patching file src/java/org/apache/lucene/search/RangeFilter.java patching file src/java/org/apache/lucene/search/RangeQuery.java Hunk #1 FAILED at 21. 1 out of 3 hunks FAILED -- saving rejects to file src/java/org/apache/lucene/search/RangeQuery.java.rej patching file src/java/org/apache/lucene/search/RangeTermEnum.java patching file src/java/org/apache/lucene/search/WildcardQuery.java patching file src/java/org/apache/lucene/search/WildcardTermEnum.java patching file src/test/org/apache/lucene/queryParser/TestQueryParser.java patching file src/test/org/apache/lucene/search/TestConstantScoreRangeQuery.java can't find file to patch at input line 1952 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: src/test/org/apache/lucene/search/TestMultiTermConstantScore.java |=================================================================== |--- src/test/org/apache/lucene/search/TestMultiTermConstantScore.java (revision 710055) |+++ src/test/org/apache/lucene/search/TestMultiTermConstantScore.java (working copy) -------------------------- File to patch: {code} Did you turn off keyword expansion in your local svn checkout? That seems to explain the first to failures (if I manually undo the $Id$ keyword expansion then the patch applies cleanly). On the 3rd failure, it seems like you renamed TestConstantScoreRangeQuery.java to TestMultiTermConstantScore.java, and then modified it? This confuses my patch client. I think I can work through these, but I sure hope this is the last patch ;) > Change all mutli term querys so that they extend MultiTermQuery and allow for > a constant score mode > --------------------------------------------------------------------------------------------------- > > Key: LUCENE-1424 > URL: https://issues.apache.org/jira/browse/LUCENE-1424 > Project: Lucene - Java > Issue Type: New Feature > Reporter: Mark Miller > Assignee: Michael McCandless > Priority: Minor > Attachments: LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch, > LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch, LUCENE-1424.patch, > LUCENE-1424.patch > > > Cleans up a bunch of code duplication, closer to how things should be - > design wise, gives us constant score for all the multi term queries, and > allows us at least the option of highlighting the constant score queries > without much further work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]