[ 
https://issues.apache.org/jira/browse/LUCENE-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael McCandless updated LUCENE-1296:
---------------------------------------

    Attachment: LUCENE-1296.patch

Paul, I reverted the changes to ChainedFilter & BooleanFilter, and instead 
deprecated the new finalResult method.  It's dangerous to just remove protected 
methods since on upgrading there will be no errors but, silently, the 
finalResult method will no longer be called.  I think in 3.0 when we remove 
these methods, rather than simply removing them we should actually mark them 
final such that any subclasses still using them will see hard compilation 
errors.

Can you look over the new patch?

> Allow use of compact DocIdSet in CachingWrapperFilter
> -----------------------------------------------------
>
>                 Key: LUCENE-1296
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1296
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>            Reporter: Paul Elschot
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: cachedFilter20080529.patch, cachedFilter20080605.patch, 
> LUCENE-1296.patch, LUCENE-1296.patch, LUCENE-1296b.patch
>
>
> Extends CachingWrapperFilter with a protected method to determine the 
> DocIdSet to be cached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to