[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655663#action_12655663
]
Mark Miller commented on LUCENE-1483:
-------------------------------------
Okay, I follow now. If you did things correctly, you'll always be passed the
right segmentreader through a hook. Nice. I think we really do want to do this
for the other search methods.
bq. Still, I agree this is probably dangerous to suddenly change, since there
could easily be filters out there that are [illegally] using a docID not
belonging/corresponding to the reader that was passed in. So maybe we should
provide a migration path. EG, add "allowSubReaders" to Filter, defaulting to
"return false" so that any external Filter impls still get passed the
Multi*Reader, and then fix all core/contrib filters to return true from that
method?
This seems reasonable. I am following your [illegal] argument better now
though, so I wouldn't feel so bad leaving it out. If its unsupported behavior,
I like the idea of adding backward compat cruft much less. I had it in my head
that you might be caching things based on the top level multireader, but it
looks like now, that you always should be using the reader provided by a hook -
which will be the single seg reader.
> Change IndexSearcher to use MultiSearcher semantics for sorted searches
> -----------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch
>
>
> Here is a quick test patch. FieldCache for sorting is done at the individual
> IndexReader level and reloading the fieldcache on reopen can be much faster
> as only changed segments need to be reloaded.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
