[ https://issues.apache.org/jira/browse/LUCENE-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1484: --------------------------------------- Attachment: LUCENE-1484.patch OK I've fixed a few issues with the patch. All tests & back-compat tests now pass. I think it's ready to commit. Jason can you review it? Details: * Fixed the bug causing test failures (we were not in fact cloning the FieldsReader in reopenSegment(), causing NPEs) * Put back the call to isDeleted() in SegmentReader.document -- we lost the synchronization by inlining it. * Move fieldStreamTL.close() back out of the "if (isOriginal)" block in FieldsReader.close. * Put lost "private" back in front of a couple methods/members * Added javadocs * Removed dead code * Added CHANGES entry * Other small fixes... > Remove SegmentReader.document synchronization > --------------------------------------------- > > Key: LUCENE-1484 > URL: https://issues.apache.org/jira/browse/LUCENE-1484 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Affects Versions: 2.4 > Reporter: Jason Rutherglen > Attachments: LUCENE-1484.patch, LUCENE-1484.patch > > Original Estimate: 96h > Remaining Estimate: 96h > > This is probably the last synchronization issue in Lucene. It is the > document method in SegmentReader. It is avoidable by using a threadlocal for > FieldsReader. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org