[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657468#action_12657468
]
markrmil...@gmail.com edited comment on LUCENE-1483 at 12/17/08 10:34 AM:
----------------------------------------------------------------
bq. Could we instead add a new HitCollector subclass, that adds the
setNextReader, then use 'instanceof' to decide whether to wrap or not?
Woah! Don't make me switch all that again! I've got wrist injuries here :) The
reason I lost the instanceof is that we would have to deprecate the
HitCollector implementations because they need to extend HitCollector. Mike
seemed against deprecating those if we could get away with it, so I've since
dropped that. I've already gone back and forth - whats it going to be ? Ill
admit I don't like using the exception trap I am now, but I dont much like the
return true/false method either...
*Edit*
Ah, I see, you have a new tweak on this time. Extend HitCollector rather then
HitCollector extending the new type...
Nice, I think this is the way to go.
was (Author: markrmil...@gmail.com):
bq. Could we instead add a new HitCollector subclass, that adds the
setNextReader, then use 'instanceof' to decide whether to wrap or not?
Woah! Don't make me switch all that again! I've got wrist injuries here :) The
reason I lost the instanceof is that we would have to deprecate the
HitCollector implementations because they need to extend HitCollector. Mike
seemed against deprecating those if we could get away with it, so I've since
dropped that. I've already gone back and forth - whats it going to be ? Ill
admit I don't like using the exception trap I am now, but I dont much like the
return true/false method either...
> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
> Key: LUCENE-1483
> URL: https://issues.apache.org/jira/browse/LUCENE-1483
> Project: Lucene - Java
> Issue Type: Improvement
> Affects Versions: 2.9
> Reporter: Mark Miller
> Priority: Minor
> Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch,
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing
> for individual segment reloading on reopen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
