[ 
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657402#action_12657402
 ] 

Mark Miller commented on LUCENE-1483:
-------------------------------------

bq. I have still one question: Why do we need the new DocCollector? Is this 
really needed? Would it be not OK to just add the offset before calling 
collect()?

If its not needed, lets get rid of it. We don't want to deprecate HitCollector 
if we don't have to. The main reason I can see that we are doing it at the 
moment is that the TopFieldValueDocCollector needs that hook so that it can set 
the next IndexReader for each Comparator. The Comparator needs it to create the 
fieldcaches and map ords from one reader to the next. Also, it lets us do the 
docBase stuff, which is nice because you add the docBase less often if done in 
the collector.

> Change IndexSearcher to use MultiSearcher semantics for multiple subreaders
> ---------------------------------------------------------------------------
>
>                 Key: LUCENE-1483
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1483
>             Project: Lucene - Java
>          Issue Type: Improvement
>    Affects Versions: 2.9
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, 
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, 
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, 
> LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch
>
>
> FieldCache and Filters are forced down to a single segment reader, allowing 
> for individual segment reloading on reopen.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to