[
https://issues.apache.org/jira/browse/LUCENE-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658062#action_12658062
]
Erik Hatcher commented on LUCENE-1387:
--------------------------------------
I've taken some quick peeks into the code, run the unit tests, nicely packaged
and presented!
A couple of thoughts:
* Maybe the Filter's should be using the DocIdSet API rather than the BitSet
deprecated stuff? We can refactor that after being committed I supposed, but
not something we want to leave like that.
* DistanceQuery is awkwardly named. It's not an (extends) Query.... it's a
POJO with helpers. Maybe DistanceQueryFactory? (but it creates a Filter also)
* CartesianPolyFilter is not a Filter (but CartesianShapeFilter is)
I think this looks good enough to commit as well, just noting the above for
cosmetic refactoring consideration after the code is in.
> Add LocalLucene
> ---------------
>
> Key: LUCENE-1387
> URL: https://issues.apache.org/jira/browse/LUCENE-1387
> Project: Lucene - Java
> Issue Type: New Feature
> Components: contrib/*
> Reporter: Grant Ingersoll
> Priority: Minor
> Attachments: spatial-lucene.zip, spatial.tar.gz, spatial.zip
>
>
> Local Lucene (Geo-search) has been donated to the Lucene project, per
> https://issues.apache.org/jira/browse/INCUBATOR-77. This issue is to handle
> the Lucene portion of integration.
> See http://lucene.markmail.org/message/orzro22sqdj3wows?q=LocalLucene
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
