Sure

On Mon, Dec 22, 2008 at 1:37 PM, Michael McCandless <
luc...@mikemccandless.com> wrote:

>
> I think this makes sense.  Can you submit patch?  Thanks Shai.
>
> Mike
>
>
> Shai Erera wrote:
>
>  Hi
>>
>> Is IndexFileNameFilter supposed to be a singleton (looks like it)?
>> If so, shouldn't its constructor be private?
>> Also, since it has a static getFilter() method, its singleton should also
>> be private.
>> I checked and there are no references to either the singleton or the
>> constructor outside this class, so the change should not cause any issues.
>>
>> Shai
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: java-dev-h...@lucene.apache.org
>
>

Reply via email to