[ https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1483: --------------------------------------- Attachment: LUCENE-1483.patch Attached full patch (though you'll get failed hunks because of the annoying $Id$ expansion problem). I fixed various small issues, and added a new TestStressSort test. It runs legacy vs new sort and asserts that they are the same. It is currently failing... but I haven't spent any time digging into why. Mark could you dig and try to figure out why it's failing? I think we should resolve it before running (or, trusting) perf tests. Also: I wonder if we can remove the null checking in the compare methods for String*Comparator? EG maybe we need a new FieldCache.getString{s,Index} methods that optionally take a "fillNulls" param, and if true nulls are replaced with empty string? However... that would unfortunately cause a difference whereby "" would be equal to null (whereas now null sorts ahead of ""), which is not back compatible. I guess we could make a "non-null" comparator and use it whenever it's known there are no nulls in the FieldCache array. It may not be worth the hassle. If the value is never null, cpu will guess the right branch path every time, so penalty should be small (yet non-zero!). > Change IndexSearcher multisegment searches to search each individual segment > using a single HitCollector > -------------------------------------------------------------------------------------------------------- > > Key: LUCENE-1483 > URL: https://issues.apache.org/jira/browse/LUCENE-1483 > Project: Lucene - Java > Issue Type: Improvement > Affects Versions: 2.9 > Reporter: Mark Miller > Priority: Minor > Attachments: LUCENE-1483-partial.patch, LUCENE-1483.patch, > LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, > LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, > LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, > LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, > LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, > LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, LUCENE-1483.patch, > sortBench.py, sortCollate.py > > > FieldCache and Filters are forced down to a single segment reader, allowing > for individual segment reloading on reopen. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org