[
https://issues.apache.org/jira/browse/LUCENE-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1476:
---------------------------------------
Attachment: LUCENE-1476.patch
I had some trouble w/ the latest patch (I'm trying to reproduce your
strange problem w/ contrib/benchmark & run perf tests):
* MultiDocIdSet was missing (I just pulled from earlier patch)
* Compilation errors because {Filter,Parallel}IndexReader failed to
mark getDeletedDocs public (I made them public).
* contrib/instantiated failed to compile, because its IndexReader
impl failed to implement getDocIdSet... but we can't add abstract
IndexReader.getDocIdSet (this breaks back compat). I switched to
non-abstract default method that throws
UnsupportedOperationException instead, and added nocommit comment
to remind us to fix all IndexReader subclasses in contrib.
* I don't think you should change MemoryIndexReader from private to
public? Why was that done? (I reverted this).
* Replaced MemoryIndex.NullDocIdSet with the new
DocIdSet.EMPTY_DOCIDSET
* Somehow you lost recent fixes to MemoryIndex.java (committed as
part of LUCENE-1316). This was causing NPE test failure (I
reverted this, test passes now).
New patch attached. All tests pass... next I'll try to repro the
contrib/benchmark oddness.
> BitVector implement DocIdSet, IndexReader returns DocIdSet deleted docs
> -----------------------------------------------------------------------
>
> Key: LUCENE-1476
> URL: https://issues.apache.org/jira/browse/LUCENE-1476
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.4
> Reporter: Jason Rutherglen
> Priority: Trivial
> Attachments: LUCENE-1476.patch, LUCENE-1476.patch, LUCENE-1476.patch,
> LUCENE-1476.patch, LUCENE-1476.patch, quasi_iterator_deletions.diff,
> quasi_iterator_deletions_r2.diff, searchdeletes.alg, TestDeletesDocIdSet.java
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> Update BitVector to implement DocIdSet. Expose deleted docs DocIdSet from
> IndexReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
