[
https://issues.apache.org/jira/browse/LUCENE-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676714#action_12676714
]
Hoss Man commented on LUCENE-1500:
----------------------------------
bq. Perhaps we can turn this around and ask "under what conditions is it
acceptable to provide a TokenStream with tokens whose offsets exceed the length
of the text provided?". Not sure I see a justifiable case for supporting that
as a legitimate scenario and I would prefer the reporting of an error in this
case.
+ 1 to reporting an error ... but StringIndexOutOfounds is not a helpful error.
Code should certainly check the offsets before calling substring and throw a
specific exception identifying which token has an invalid offset
> Highlighter throws StringIndexOutOfBoundsException
> --------------------------------------------------
>
> Key: LUCENE-1500
> URL: https://issues.apache.org/jira/browse/LUCENE-1500
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Affects Versions: 2.4
> Environment: Found this running the example code in Solr (latest
> version).
> Reporter: David Bowen
> Assignee: Michael McCandless
> Fix For: 2.4.1, 2.9
>
> Attachments: LUCENE-1500.patch, patch.txt
>
>
> Using the canonical Solr example (ant run-example) I added this document
> (using exampledocs/post.sh):
> <add><doc>
> <field name="id">Test for Highlighting
> StringIndexOutOfBoundsExcdption</field>
> <field name="name">Some Name</field>
> <field name="manu">Acme, Inc.</field>
> <field name="features">Description of the features, mentioning various
> things</field>
> <field name="features">Features also is multivalued</field>
> <field name="popularity">6</field>
> <field name="inStock">true</field>
> </doc></add>
> and then the URL
> http://localhost:8983/solr/select/?q=features&hl=true&hl.fl=features caused
> the exception.
> I have a patch. I don't know if it is completely correct, but it avoids this
> exception.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
