On Apr 1, 2009, at 5:29 AM, Shai Erera (JIRA) wrote:


[ https://issues.apache.org/jira/browse/LUCENE-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694443 #action_12694443 ]

Shai Erera commented on LUCENE-1575:
------------------------------------

I did not do any "svn copy", just used Eclipse refactoring to change the name of the class to Collector. I did not understand though from your comment if I should do it differently and post another patch, or is that a hint to how someone can still apply the patch?

Assuming you have Subclipse installed into Eclipse:

Subclipse will do an svn rename (aka move) when refactoring names. It does an add of the new name and a delete of the old, but retains history of the file. This is equal to svn copy followed by svn delete.

If you create a copy of a file inside of Eclipse, Subclipse will do an svn copy.

There is a Subclipse property DeferFileDelete that when set (with a value of "true") on a folder will change the delete behavior of all files below it. I set it on the root of my Eclipse projects, because I don't like Subclipse's delete behavior.

I don't understand how it could mess up patching.

I think what was suggested was to go to the file system and do an OS copy of the file. Or use Eclipse without Subclipse.

-- DM



---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to