[ https://issues.apache.org/jira/browse/LUCENE-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705128#action_12705128 ]
Uwe Schindler commented on LUCENE-1623: --------------------------------------- Hi Mike, a little bit too late, but there is a small flow-error in handling of the IOException in FieldInfos ctor: {code} } catch (IOException ioe) { if (format == FORMAT_PRE) { ... } } {code} The problem: If the IOException occurs and the Format is not FORMAT_PRE, the Exception should be re-thrown. And here a suggestion: {code} byNumber = new ArrayList(); byName = new HashMap(); {code} I would simply clear() the two collections... > Back-compat break with non-ascii field names > -------------------------------------------- > > Key: LUCENE-1623 > URL: https://issues.apache.org/jira/browse/LUCENE-1623 > Project: Lucene - Java > Issue Type: Bug > Components: Index > Affects Versions: 2.4, 2.4.1 > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 2.9 > > Attachments: LUCENE-1623.patch > > > If a field name contains non-ascii characters in a 2.3.x index, then > on upgrade to 2.4.x unexpected problems are hit. It's possible to hit > a "read past EOF" IOException; it's also possible to not hit an > exception but get an incorrect field name. > This was caused by LUCENE-510, because the FieldInfos (*.fnm) file is > not properly versioned. > Spinoff from http://www.nabble.com/Read-past-EOF-td23276171.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org