[ 
https://issues.apache.org/jira/browse/LUCENE-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711578#action_12711578
 ] 

Michael McCandless commented on LUCENE-1648:
--------------------------------------------

{quote}
Or to be more exact, it fixed the tests that were failing for me.
Your two new tests fail as soon as I apply "always use MSR", because MSR does 
not carry over hasChanges/hasDeletions on clone().
{quote}
Hmm, OK so it's a good news / bad news situation.

Good news is patch resolved your original issue.  I'll commit it shortly.

Bad news is something is wrong w/ your patch, because MSR needs to carry over 
hasChanges/deletions/norms on clone().

> when you clone or reopen an IndexReader with pending changes, the new reader 
> doesn't commit the changes
> -------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1648
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1648
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1648.patch
>
>
> While working on LUCENE-1647, I came across this issue... we are failing to 
> carry over hasChanges, norms/deletionsDirty, etc, when cloning the new reader.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to