It looks like this was done in order to implement SegmentTermDocs.read(int[], int[]) natively, when using a gcj environment, since that gave performance improvements?
I agree we should probably remove it, unless there are users relying on this. Maintaining side-by-side sources is difficult with time. Also, this seems like something source code specialization (LUCENE-1594) should cover. Can you send an email to java-user to take a quick survey on whether anyone is somehow needing this? Mike On Thu, May 21, 2009 at 10:17 AM, Earwin Burrfoot <ear...@gmail.com> wrote: > Right now a set of system properties and Class.newInstance() is used > to create SegmentReader. > > I've tracked down this code's origins to: > r150531 | cutting | 2004-09-22 22:32:27 +0400 (ср, 22 сен 2004) | 2 lines > Add GCJ native code for SegmentTermDocs.read(int[],int[]) to > accellerate TermScorer. TermScorer and BooleanScorer are now usually > a bit faster under GCJ than under Sun's JVM. > > Anybody uses this? Let's just go ahead, scrap it, and construct > classes using er.. constructors? :) > No adequate docs for this feature exist, except a very brief mention > in CHANGES.txt. > Even more - when ReadonlySegmentReader was introduced, instantiation > code was blindly copypasted, but no matching GCJReadonlySegmentReader > was created and corresponding Makefile wasn't altered, thus > GCJ-optimized Lucene is currently broken on trunk. > Removal of this feature also won't break any theoretical old apps that > magically happen to use it, because we'll simply ignore the property > with zero change in runtime behaviour. > > -- > Kirill Zakharenko/Кирилл Захаренко (ear...@gmail.com) > Home / Mobile: +7 (495) 683-567-4 / +7 (903) 5-888-423 > ICQ: 104465785 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-dev-h...@lucene.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
