[ https://issues.apache.org/jira/browse/LUCENE-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718039#action_12718039 ]
Simon Willnauer commented on LUCENE-1679: ----------------------------------------- I created a new patch containing the #close() method. I 100% believe you about your comment but I have a hard time to understand why it breaks back-compat. Could you give me a quick explanation please I might miss something. Thanks, Simon > Make WildcardTermEnum#difference() non-final > -------------------------------------------- > > Key: LUCENE-1679 > URL: https://issues.apache.org/jira/browse/LUCENE-1679 > Project: Lucene - Java > Issue Type: Improvement > Components: Search > Affects Versions: 2.9 > Reporter: Simon Willnauer > Assignee: Michael McCandless > Priority: Minor > Fix For: 2.9 > > Attachments: WildcardTermEnum.patch, WildcardTermEnum_cleanup.patch, > WildcardTermEnum_cleanup_2nd.patch > > > The method WildcardTermEnum#difference() is declared final. I found it very > useful to subclass WildcardTermEnum to implement different scoring for exact > vs. partial matches. The change is rather trivial (attached) but I guess it > could make life easier for a couple of users. > I attached two patches: > - one which contains the single change to make difference() non-final > (WildcardTermEnum.patch) > - one which does also contain some minor cleanup of WildcardTermEnum. I > removed unnecessary member initialization and made those final. ( > WildcardTermEnum_cleanup.patch) > Thanks simon -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org