[ 
https://issues.apache.org/jira/browse/LUCENE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720578#action_12720578
 ] 

Michael McCandless commented on LUCENE-1699:
--------------------------------------------


Patch looks good:

  * Can you make sure CHANGES describes this new behavior (Field is
    allowed to have both a tokenStream and a String/Reader/binary
    value)?

  * The javadoc for readerValue is wrong (copy/paste from stringValue)

  * Can you spell out more clearly in the javadocs that even when a
    tokenStream value is set, one of String/Reader/binary may also be
    set, or, not, and if so, that "other" value is only used for
    stored fields.  Eg, explain why one would use setTokenStream
    instead of setValue(TokenStream value).


> Field tokenStream should be usable with stored fields.
> ------------------------------------------------------
>
>                 Key: LUCENE-1699
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1699
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Yonik Seeley
>            Assignee: Yonik Seeley
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1699.patch
>
>
> Field.tokenStream should be usable for indexing even for stored values.  
> Useful for many types of pre-analyzed values (text/numbers, etc)
> http://search.lucidimagination.com/search/document/902bad4eae20bdb8/field_tokenstreamvalue

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to