[ https://issues.apache.org/jira/browse/LUCENE-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721024#action_12721024 ]
Jason Rutherglen commented on LUCENE-1700: ------------------------------------------ Taking a step back, maybe we can solve the package protected SegmentInfo issue here by creating a new class with the necessary attributes? Here's what LUCENE-1313 does: {code} SegmentReader sr = writer.readerPool.getIfExists(info); if (info.hasDeletions() || (sr != null && sr.hasDeletions())) { {code} Because SegmentInfo is package protected it seems ok to access a package protected method (or in this case variable) in IndexWriter. > LogMergePolicy.findMergesToExpungeDeletes need to get deletes from the > SegmentReader > ------------------------------------------------------------------------------------ > > Key: LUCENE-1700 > URL: https://issues.apache.org/jira/browse/LUCENE-1700 > Project: Lucene - Java > Issue Type: Bug > Components: Index > Affects Versions: 2.4.1 > Reporter: Jason Rutherglen > Priority: Trivial > Fix For: 2.9 > > Original Estimate: 48h > Remaining Estimate: 48h > > With LUCENE-1516, deletes are carried over in the SegmentReaders > which means implementations of > MergePolicy.findMergesToExpungeDeletes (such as LogMergePolicy) > need to obtain deletion info from the SR (instead of from the > SegmentInfo which won't have the information). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org