[
https://issues.apache.org/jira/browse/LUCENE-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721711#action_12721711
]
Michael McCandless commented on LUCENE-1692:
--------------------------------------------
Latest patch looks good Robert, thanks!
Deprecating DutchAnalyzer (in favor of Snowball) makes sense to me -- any
objections out there?
(And I'll "svn rm" the two large & unused files).
Robert, could you open a new issue for the Thai token type bug (that requires a
change to StandardTokenizer's grammar)? We seem to be accumulating a number of
these "fix StandardTokeninizer's grammar" but we don't have a good way to do
this back-compatibly... matchVersion is a good way for the user to express
compatibility requirement, but we don't know how to [cleanly] switch on that to
different grammar variants.
Is that the only issue not addressed by the latest patch?
> Contrib analyzers need tests
> ----------------------------
>
> Key: LUCENE-1692
> URL: https://issues.apache.org/jira/browse/LUCENE-1692
> Project: Lucene - Java
> Issue Type: Test
> Components: contrib/analyzers
> Reporter: Robert Muir
> Assignee: Michael McCandless
> Fix For: 2.9
>
> Attachments: example.jpg, LUCENE-1692.txt, LUCENE-1692.txt,
> LUCENE-1692.txt, LUCENE-1692.txt, LUCENE-1692.txt, LUCENE-1692.txt,
> LUCENE-1692.txt
>
>
> The analyzers in contrib need tests, preferably ones that test the behavior
> of all the Token 'attributes' involved (offsets, type, etc) and not just what
> they do with token text.
> This way, they can be converted to the new api without breakage.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
