[ 
https://issues.apache.org/jira/browse/LUCENE-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725771#action_12725771
 ] 

Simon Willnauer commented on LUCENE-1722:
-----------------------------------------

bq. I thought this was most important for now, since it would be what the users 
see. 

I agree, those are most important. I really appreciate this doc work, again 
thanks for that. I would like to have this in for 2.9 preferably with all 
chinese documentation replaced. Would be greate if you could do it! 

bq. all the classes are in public scope, and many internal-only classes should 
instead be package protected (imho). This might involve reorganizing the files 
a bit.

agreement again. I would rather do that in a second patch / issue as soon as 
this one is commited. Would this remove some of the addtional documentation 
work? If so you can leave those as they are.

simon

> SmartChineseAnalyzer javadoc improvement
> ----------------------------------------
>
>                 Key: LUCENE-1722
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1722
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Robert Muir
>            Assignee: Simon Willnauer
>            Priority: Minor
>         Attachments: LUCENE-1722.txt
>
>
> Chinese -> English, and corrections to match reality (removes several javadoc 
> warnings)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to