[ 
https://issues.apache.org/jira/browse/LUCENE-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726362#action_12726362
 ] 

Simon Willnauer commented on LUCENE-1728:
-----------------------------------------

bq. After creating the new contrib, do not forget to add the javadocs 
generation of the "all/" subdir in the main build.xml! Also new contribs should 
be added to the developers part in the site docs and so on. I can do that if 
you like after committing the whole thing (I have done it several times the 
last months for spatial, trie,...). 
Uwe, I will not be able to commit those changes I guess. This reminds me that 
contrib commiters should have access to those files too. Once I get this change 
in I will notify you with a patch so you can get it in.

bq. This approach is only good for source code, the user still gets the jar 
files in the main build folder directly under contrib. So I am not sure, if 
this is really better than two really separate contribs.
I really like this approach as it keeps the code logically consistent. I think 
we should go for this approach, that makes much more sense to me.


> Move SmartChineseAnalyzer & resources to own contrib project
> ------------------------------------------------------------
>
>                 Key: LUCENE-1728
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1728
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/analyzers
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Minor
>             Fix For: 2.9
>
>
> SmartChineseAnalyzer depends on  a large dictionary that causes the analyzer 
> jar to grow up to 3MB. The dictionary is quite big compared to all the other 
> resouces / class files contained in that jar. 
> Having a separate analyzer-cn contrib project enables footprint-sensitive 
> users (e.g. using lucene on a mobile phone) to include analyzer.jar without 
> getting into trouble with disk space.
> Moving SmartChineseAnalyzer to a separate project could also include a small 
> refactoring as Robert mentioned in 
> [LUCENE-1722|https://issues.apache.org/jira/browse/LUCENE-1722] several 
> classes should be package protected, members and classes could be final, 
> commented syserr and logging code should be removed etc.
> I set this issue target to 2.9 - if we can not make it until then feel free 
> to move it to 3.0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to