[ https://issues.apache.org/jira/browse/LUCENE-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730030#action_12730030 ]
Jason Rutherglen commented on LUCENE-1726: ------------------------------------------ Another idea is instantiate the SR.core.ref outside of the IW.readerPool, and pass it into the newly created reader. Then when we obtain SRMapValue, incref so we're keeping track of it's usage, which (I believe) should be inline with the normal usage of SR.ref (meaning don't close the reader if SRMV is checked out). This way we know when the SRMV is in use and different threads don't clobber each other creating and closing SRs using readerPool. > IndexWriter.readerPool create new segmentReader outside of sync block > --------------------------------------------------------------------- > > Key: LUCENE-1726 > URL: https://issues.apache.org/jira/browse/LUCENE-1726 > Project: Lucene - Java > Issue Type: Improvement > Components: Index > Affects Versions: 2.4.1 > Reporter: Jason Rutherglen > Assignee: Michael McCandless > Priority: Trivial > Fix For: 3.1 > > Attachments: LUCENE-1726.patch, LUCENE-1726.patch, LUCENE-1726.patch, > LUCENE-1726.patch, LUCENE-1726.patch, LUCENE-1726.patch, > LUCENE-1726.trunk.test.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > I think we will want to do something like what field cache does > with CreationPlaceholder for IndexWriter.readerPool. Otherwise > we have the (I think somewhat problematic) issue of all other > readerPool.get* methods waiting for an SR to warm. > It would be good to implement this for 2.9. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org