[ 
https://issues.apache.org/jira/browse/LUCENE-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731993#action_12731993
 ] 

Michael McCandless commented on LUCENE-1505:
--------------------------------------------

bq. For completeness, shoudl we also add them for the ones with the shift value 
at the end? an char[]? I was reluctant to do this.

Let's hold off & add these when the need first arises?

bq. I wonder if it would make sense to do some cleanup in the code (final vars 
and args etc.) and if we should remove this logging code

Agreed -- looks like you've opened a new issue for this already; thanks!

I'll commit shortly.

> Change contrib/spatial to use trie's NumericUtils, and remove NumberUtils
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-1505
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1505
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>            Reporter: Ryan McKinley
>            Assignee: Michael McCandless
>             Fix For: 2.9
>
>         Attachments: LUCENE-1505.patch
>
>
> Currently spatial contrib includes a copy of NumberUtils from solr (otherwise 
> it would depend on solr)
> Once LUCENE-1496 is sorted out, this copy should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to