[ https://issues.apache.org/jira/browse/LUCENE-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734433#action_12734433 ]
Hoss Man commented on LUCENE-1749: ---------------------------------- Hmmm... somehow i overlooked the fact that even after i "fixed" TestRemoteSort in the last patch, it's still failing. Here's the assertion failure... {code} junit.framework.AssertionFailedError: testRemoteCustomSort Comparator: multi FieldCaches for same reader/fieldname with diff types at org.apache.lucene.util.LuceneTestCase.assertSaneFieldCaches(LuceneTestCase.java:110) at org.apache.lucene.search.TestRemoteSort.testRemoteCustomSort(TestRemoteSort.java:261) at org.apache.lucene.util.LuceneTestCase.runTest(LuceneTestCase.java:265) {code} ...and here's the debugging dump of the FieldCache... {code} *** BEGIN testRemoteCustomSort Comparator: FieldCache Losers *** 'org.apache.lucene.index.directoryrea...@1108727'=>'custom',interface java.lang.Comparable,9,org.apache.lucene.search.samplecomparabl...@651e95,null=>[Ljava.lang.Comparable;#22056753 size guess:2 KB 'org.apache.lucene.index.directoryrea...@1108727'=>'custom',interface java.lang.Comparable,9,org.apache.lucene.search.samplecomparabl...@5b78cf,null=>[Ljava.lang.Comparable;#32045680 size guess:2 KB *** END testRemoteCustomSort Comparator: FieldCache Losers *** *** BEGIN org.apache.lucene.search.TestRemoteSort.testRemoteCustomSort: FieldCache Losers *** 'org.apache.lucene.index.directoryrea...@1108727'=>'custom',interface java.lang.Comparable,9,org.apache.lucene.search.samplecomparabl...@651e95,null=>[Ljava.lang.Comparable;#22056753 size guess:2 KB 'org.apache.lucene.index.directoryrea...@1108727'=>'custom',interface java.lang.Comparable,9,org.apache.lucene.search.samplecomparabl...@5b78cf,null=>[Ljava.lang.Comparable;#32045680 size guess:2 KB *** END org.apache.lucene.search.TestRemoteSort.testRemoteCustomSort: FieldCache Losers *** {code} What really confuses me about this is that the same SampleComparable instance is being used with two different queries -- once with reverse=true and once with reverse=false, yet two different SampleComparable instances are showing up in cache keys -- the probably only happens when SampleComparable is used to get a SortComparator -- not when it uses a ComparatorSource earlier in the test. Is this a real bug in remote sorting? > FieldCache introspection API > ---------------------------- > > Key: LUCENE-1749 > URL: https://issues.apache.org/jira/browse/LUCENE-1749 > Project: Lucene - Java > Issue Type: Improvement > Components: Search > Reporter: Hoss Man > Priority: Minor > Fix For: 2.9 > > Attachments: fieldcache-introspection.patch, LUCENE-1749.patch, > LUCENE-1749.patch, LUCENE-1749.patch > > > FieldCache should expose an Expert level API for runtime introspection of the > FieldCache to provide info about what is in the FieldCache at any given > moment. We should also provide utility methods for sanity checking that the > FieldCache doesn't contain anything "odd"... > * entries for the same reader/field with different types/parsers > * entries for the same field/type/parser in a reader and it's subreader(s) > * etc... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org