> >> > I found out that clover-setup supports a special advanced tag > >> > "<testsources>": > >> > <testsources> is an Ant fileset which should only be used if Clover's > >> > default test detection is not adequate. Clover's default test > detection > >> > algorithm is used to distinguish test cases if this element is > omitted. > >> > >> That sounds promising! > >> > >> Atlassian actually proactively contacted me about this build failure > >> (how responsive is that!), offering to look into this "zero bytes > >> source file issue", upgrade Apache's license to clover 2.0 and work > >> out a patch for Lucene to switch to 2.0. I'll open an issue once they > >> send the patch over. > > > > I switched over to clover 2.4.3 here locally, changed common-build.xml > and > > now it seems to work. > > Excellent.
I for got to mention: <testsources> only works for clover 2.x this is why I updated. The update was simple, I only had to change one line in common-build.xml and add the testsources tag with the current junit.include/exclude and ASCIIFoldingFilter exclusions. Addition of test-tag is more complicated, as the source directory names are not so simple to find and are not available at the time of setup-clover task. I will post a patch after the complete ant test has run here in complete (will take some time). > >> > And it seems that clover uses the backwards tests and nothing else. I > >> > install clover locally and try out. I will then open an issue. > >> > >> We should definitely fix that. I think it's best to instrument both > >> the trunk's tests and the back-compat tests if we can. > > > > Currently I only instument the contrib and core tests. If we also > instrument > > backwards tests, we may have code not instrumented by current tests, > only > > the backwards tests. In my opinion, you should see the coverage of > current > > tests to be sure, that current test cover all code. > > Can't we see coverage of core code, by both the current unit tests and > the back-compat unit tests? We would see, my intention is to only instrument the coe/contrib tests to find out places were the test does not cover all code, but a previous test from test-tag had done. In ideal world all test of current trunk should test all code without the help of test-tag. Uwe --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
