[
https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-1504:
---------------------------------------
Attachment: LUCENE-1504.patch
OK I reworked a number of things about distance filtering:
- Switched to FilteredDocIdSet to do "serial anding"
- DistanceFilter now requires a starting filter; normally in spatial
there is already a starting filter (using geohash or lat/lng
tiers), so I think this should be fine. And one can always do
QueryWrapperFilter(MatchAllDocsQuery()) as a no-op filter.
- Moved stuff into the base class, DistanceFilter
- Fixed one bug, where the saved distances were getting overwritten
per-segment
- Fixed another bug where GeoHashDistanceFilter was adding a
distance into the distances hash even if it didn't pass the filter
(ie distance was too big); this required a fix to one of the tests
- Use Double.toString\(n) instead of new Double\(n).toString()
- Added DistanceFilter.reset, which you must call before reusing the
filter across searches
- Commented out the precision-defaulting logic: it was buggy (used
the segment maxDoc() instead of per-reader), and, it wasn't
actually used (the code that applies precision was commented out
for both LatLong and GeoHash)
- Removed some logging calls (I know there's another issue open to
do more cleanups)
> SerialChainFilter should use DocSet API rather then deprecated BitSet API
> -------------------------------------------------------------------------
>
> Key: LUCENE-1504
> URL: https://issues.apache.org/jira/browse/LUCENE-1504
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1504.patch, LUCENE-1504.patch, LUCENE-1504.patch
>
>
> From erik's comments in LUCENE-1387
> * Maybe the Filter's should be using the DocIdSet API rather than the
> BitSet deprecated stuff? We can refactor that after being committed I
> supposed, but not something we want to leave like that.
> We should also look at moving SerialChainFilter out of the spatial contrib
> since it is more generally useful then just spatial search.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
