[ https://issues.apache.org/jira/browse/LUCENE-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737679#action_12737679 ]
Robert Muir commented on LUCENE-1689: ------------------------------------- one tricky part of this is CharTokenizer. a few things subclass this guy. * Sometimes it is ok (WhitespaceTokenizer, because all whitespace in unicode <= 0xFFFF) * Sometimes it is not (LetterTokenizer) It depends how its being used. So I think instead of just {code} abstract boolean isTokenChar(char) char normalize(char) {code} we can add additional int-based methods, where the default implementation is to defer to the char-based ones. This would preserve backwards compatibility. > supplementary character handling > -------------------------------- > > Key: LUCENE-1689 > URL: https://issues.apache.org/jira/browse/LUCENE-1689 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Robert Muir > Priority: Minor > Fix For: 3.1 > > Attachments: LUCENE-1689_lowercase_example.txt, > testCurrentBehavior.txt > > > for Java 5. Java 5 is based on unicode 4, which means variable-width encoding. > supplementary character support should be fixed for code that works with > char/char[] > For example: > StandardAnalyzer, SimpleAnalyzer, StopAnalyzer, etc should at least be > changed so they don't actually remove suppl characters, or modified to look > for surrogates and behave correctly. > LowercaseFilter should be modified to lowercase suppl. characters correctly. > CharTokenizer should either be deprecated or changed so that isTokenChar() > and normalize() use int. > in all of these cases code should remain optimized for the BMP case, and > suppl characters should be the exception, but still work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org