[ 
https://issues.apache.org/jira/browse/LUCENE-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738109#action_12738109
 ] 

Shai Erera commented on LUCENE-1774:
------------------------------------

That is indeed new (I added it in LUCENE-1595 as part of the general 
refactoring). Now PerfTask includes logging logic, determined by log.step. It 
means that one log.step controls all tasks, which I'm not sure if it's good or 
not (doc.delete.log.step controls just deletes because it seemed to be used by 
several algs).

Maybe, as part of this issue or another issue, we can have PerfTask support a 
parameter, which will be the log.step? That way you can choose to 
AddDocTask(100), and SearchTask(-1) to enable logging for adding docs and 
disable for search. Though that will conflict w/ the other parameter AddDocTask 
supports (document size). So perhaps we can enhance the parameters to accept a 
list? Just a thought.

> In a benchmark alg, if you use a log.step thats higher than the number of 
> docs you add, whacky high numbers are logged for doc adds
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-1774
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1774
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/benchmark
>            Reporter: Mark Miller
>            Priority: Trivial
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to