[
https://issues.apache.org/jira/browse/LUCENE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739949#action_12739949
]
Michael McCandless commented on LUCENE-1782:
--------------------------------------------
{quote}
My reason for this, is that this change will make it more difficult for users
that want to use several implementations of diff parsers at same time.
{quote}
Well... simple things should be simple; complex things should be
possible.
I expect the vast majority of Lucene users will use the standard
QueryParser, as is. We should make things as simple as possible for
such users.
Then, more advanced users will absolutely love the modularity of this
new QueryParser and cherry pick the parts they want to build up their
own parsing chain. Things need not be simple for such users; just
possible.
bq. I don't like the idea of "stripped Standard prefix" or
"StandardQueryParserHelper to simply QueryParser".
OK I do agree naming conflicts are a real hassle, and keeping this
prefix doesn't harm the "simple" case...
So I'll put back the prefixes to the Standard* classes, move the
'original' package to 'standard'. So it'll be StandardQueryParser and
the simple usage is like this:
{code}
StandardQueryParser parser = new StandardQueryParser(analyzer);
Query q = parser.parse("a OR b OR c", "field");
{code}
{quote}
I think I forgot to add a readme.txt to that folder describing how to build the
OriginalQueryParser.jj.
Can you please add that as part of this patch with the text in the comment
above, If you are busy
let know I can submit another patch with that.
{quote}
OK will do.
> Rename OriginalQueryParserHelper
> --------------------------------
>
> Key: LUCENE-1782
> URL: https://issues.apache.org/jira/browse/LUCENE-1782
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Affects Versions: 2.9
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1782.patch
>
>
> We should rename the new QueryParser so it's clearer that it's
> Lucene's default QueryParser, going forward, and not just a temporary
> "bridge" to a future new QueryParser.
> How about we rename oal.queryParser.original -->
> oal.queryParser.standard (can't use "default": it's a Java keyword)?
> Then, leave the OriginalQueryParserHelper under that package, but
> simply rename it to QueryParser?
> This way if we create other sub-packages in the future, eg
> ComplexPhraseQueryParser, they too can have a QueryParser class under
> them, to make it clear that's the "top" class you use to parse
> queries.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
