[ 
https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744759#action_12744759
 ] 

Tim Smith commented on LUCENE-1821:
-----------------------------------

I'll prepare a patch in the morning (unless someone beats me to it) and look 
over the changelog then to suggest some more disclaimers (if what's there isn't 
sufficient)

I don't hold the contract that Weight be serializable (so i'm safe there)

i agree that per-segment is the way to go in general and should be as tight as 
possible (as long as i can get my mits on the "sub readers")

but there are use cases that still require looking at the index as a whole as 
well
especially if you need to know the number of unique terms for a field, or 
otherwise need documents in one segment to be aware of documents in other 
segments (i could probably come up a bunch more use cases there)


> Weight.scorer() not passed doc offset for "sub reader"
> ------------------------------------------------------
>
>                 Key: LUCENE-1821
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1821
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Search
>    Affects Versions: 2.9
>            Reporter: Tim Smith
>
> Now that searching is done on a per segment basis, there is no way for a 
> Scorer to know the "actual" doc id for the document's it matches (only the 
> relative doc offset into the segment)
> If using caches in your scorer that are based on the "entire" index (all 
> segments), there is now no way to index into them properly from inside a 
> Scorer because the scorer is not passed the needed offset to calculate the 
> "real" docid
> suggest having Weight.scorer() method also take a integer for the doc offset
> Abstract Weight class should have a constructor that takes this offset as 
> well as a method to get the offset
> All Weights that have "sub" weights must pass this offset down to created 
> "sub" weights

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to