[ https://issues.apache.org/jira/browse/LUCENE-1821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745039#action_12745039 ]
Mark Miller commented on LUCENE-1821: ------------------------------------- I think thats a good idea. I think that last sentence needs a bit of work. Here is another attempt that I am still not quite happy with: {code}13. LUCENE-1483: When searching over multiple segments, a new Scorer is created for each segment. The Weight is created only once for the top level searcher. Each Scorer is passed the per-segment IndexReader. This will result in docids in the Scorer being internal to the per-segment IndexReader and there is currently no way to rebase these docids to the top level IndexReader. This will likely break any caches/filters in Scorers that rely on docids from the top level IndexReader eg if you rely on the IndexReader to contain every doc id in the index.{code} > Weight.scorer() not passed doc offset for "sub reader" > ------------------------------------------------------ > > Key: LUCENE-1821 > URL: https://issues.apache.org/jira/browse/LUCENE-1821 > Project: Lucene - Java > Issue Type: Bug > Components: Search > Affects Versions: 2.9 > Reporter: Tim Smith > > Now that searching is done on a per segment basis, there is no way for a > Scorer to know the "actual" doc id for the document's it matches (only the > relative doc offset into the segment) > If using caches in your scorer that are based on the "entire" index (all > segments), there is now no way to index into them properly from inside a > Scorer because the scorer is not passed the needed offset to calculate the > "real" docid > suggest having Weight.scorer() method also take a integer for the doc offset > Abstract Weight class should have a constructor that takes this offset as > well as a method to get the offset > All Weights that have "sub" weights must pass this offset down to created > "sub" weights -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org