[
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746919#action_12746919
]
Mark Miller commented on LUCENE-1847:
-------------------------------------
bq. Can we name it IDFExplain instead of IdfExplain? Nit-picky I know, but I
try to do all caps when the thing is already an acronym.
Yup, sounds good.
bq. Shouldn't we deprecate Similarity's idf methods that return float?
Yes - I've done that locally - just didn't concentrate it on this patch because
I hadn't solved the back compat problems yet.
bq. You may want to defer calling IdfExplain.explain() until the Weight's
explain is invoked?
+1
bq. On back-compat... we could check (using reflection) if the subclass has
overridden it, and in that case forward to the subclass's method, with some
canned explanation eg "inexplicable"
Ugg ... at least this code isn't performance sensitive :) I'll work with that.
> PhraseQuery/TermQuery use IndexReader specific stats in their explains
> ----------------------------------------------------------------------
>
> Key: LUCENE-1847
> URL: https://issues.apache.org/jira/browse/LUCENE-1847
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1847.patch
>
>
> PhraseQuery uses IndexReader in explainfor top level stats - as mentioned by
> Mike McCandless in LUCENE-1837.
> TermQuery uses IndexReader in explain for top level stats
> Always been a bug with MultiSearcher, but per segment search makes it worse.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
