[
https://issues.apache.org/jira/browse/LUCENE-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752795#action_12752795
]
Uwe Schindler commented on LUCENE-1903:
---------------------------------------
...hm, a beer is ok until now. A beer and a meal is needed if I also understand
the whole filter (I am still in the dark) - this filter is complicated so late
in the evening.
As far as I understand, this should be the correct fix. The problem was in the
change from the output buffer to the on-the-fly iterator.
> Incorrect ShingleFilter behavior when outputUnigrams == false
> -------------------------------------------------------------
>
> Key: LUCENE-1903
> URL: https://issues.apache.org/jira/browse/LUCENE-1903
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/analyzers
> Affects Versions: 2.9
> Reporter: Chris Harris
> Fix For: 2.9
>
> Attachments: LUCENE-1903.patch, LUCENE-1903_testcases.patch,
> LUCENE-1903_testcases_lucene2_4_1_version.patch,
> TEST-org.apache.lucene.analysis.shingle.ShingleFilterTest.xml
>
>
> ShingleFilter isn't working as expected when outputUnigrams == false. In
> particular, it is outputting unigrams at least some of the time when
> outputUnigrams==false.
> I'll attach a patch to ShingleFilterTest.java that adds some test cases that
> demonstrate the problem.
> I haven't checked this, but I hypothesize that the behavior for
> outputUnigrams == false got changed when the class was upgraded to the new
> TokenStream API?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
