I have not yet looked at the the patch, but after the comments at LUCENE-1911 I think isCacheable() could also return true for OpenBitSet, not only for SortedVIntList.
Regards, Paul Elschot. On Wednesday 16 September 2009 21:33:58 Michael McCandless (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/LUCENE-1911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756194#action_12756194 > ] > > Michael McCandless commented on LUCENE-1911: > -------------------------------------------- > > bq. we could add a DocIdSet.isCacheable() method > > +1 to this, and to keeping docIdSetToCache() for overriding. This is much > cleaner than trying to check for every known DocIdSet impl. > > Thanks for fixing this Uwe! > > > When using QueryWrapperFilter with CachingWrapperFilter, QueryWrapperFilter > > returns a DocIdSet that creates a Scorer, which gets cached rather than a > > bit set > > ------------------------------------------------------------------------------------------------------------------------------------------------------------- > > > > Key: LUCENE-1911 > > URL: https://issues.apache.org/jira/browse/LUCENE-1911 > > Project: Lucene - Java > > Issue Type: Bug > > Reporter: Mark Miller > > Assignee: Uwe Schindler > > Fix For: 2.9 > > > > Attachments: LUCENE-1911.patch > > > > > > there is a large performance cost to this. > > The old impl for this type of thing, QueryFilter, recommends : > > @deprecated use a CachingWrapperFilter with QueryWrapperFilter > > The deprecated QueryFilter itself also suffers from the problem because its > > now implemented using a CachingWrapperFilter and QueryWrapperFilter. > > see > > http://search.lucidimagination.com/search/document/7f54715f14b8b7a/lucene_2_9_0rc4_slower_than_2_4_1 > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-dev-h...@lucene.apache.org > > >
