[
https://issues.apache.org/jira/browse/LUCENE-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1933:
----------------------------------
Description:
I found some places in contrib tests, where the Token.class was added using
addAttributeImpl(). The problem here is, that you cannot be sure, that the
attribute is really added and you may fail later (because you only update your
local instance). The tests in contrib will partially fail with 3.0 without
backwards layer (because the backwards layer uses Token/TokenWrapper internally
and copyTo() will work.
The correct way to achieve this is using an AttributeFactory. The
AttributeFactory is currently private in SingleTokenTokenStream. I want to move
it to Token.java as a static class / static member. In this case the tests can
be rewritten.
I also want to mark addAttributeImpl() as EXPERT, because you must really know
whats happening and what are the traps.
was:
I found some places in contrib tests, where the Token.class was added using
addAttributeImpl(). The problem here is, that you cannot be sure, that the
attribute is really added and you may fail later (because you only update your
local instance). The tests in contrib will partially fail with 3.0 without
backwards layer (because the backwards layer uses Token/TokenWrapper internally
and copyTo() will work.
The correct way to achieve this is using an AttributeFactory. The
AttributeFactory is currently private in EmptyTokenTokenStream. I want to move
it to Token.java as a static class / static member. In this case the tests can
be rewritten
I also want to mark addAttributeImpl() as EXPERT, because you must really know
whats happening and what are the traps.
> Provide an convenience AttributeFactory that implements all default
> attributes with Token
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-1933
> URL: https://issues.apache.org/jira/browse/LUCENE-1933
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Affects Versions: 2.9
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
>
> I found some places in contrib tests, where the Token.class was added using
> addAttributeImpl(). The problem here is, that you cannot be sure, that the
> attribute is really added and you may fail later (because you only update
> your local instance). The tests in contrib will partially fail with 3.0
> without backwards layer (because the backwards layer uses Token/TokenWrapper
> internally and copyTo() will work.
> The correct way to achieve this is using an AttributeFactory. The
> AttributeFactory is currently private in SingleTokenTokenStream. I want to
> move it to Token.java as a static class / static member. In this case the
> tests can be rewritten.
> I also want to mark addAttributeImpl() as EXPERT, because you must really
> know whats happening and what are the traps.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
