Earwin Burrfoot wrote: > As I stated in my last email, there's zero difference between > settings+static factory and builder except for syntax. Cannot > understand what Mark, Mike are arguing about. > Sounds like we are arguing that we don't like the syntax then... > kill setting methods that delegate to IW components (eg > MergePolicy), as they are redundant and suddenly break if you supply a > non-default component instance. > I do agree that this is something that should be addressed.
> On Sun, Oct 4, 2009 at 17:55, Yonik Seeley <ysee...@gmail.com> wrote: > >> On Sun, Oct 4, 2009 at 5:53 AM, Michael McCandless >> <luc...@mikemccandless.com> wrote: >> >>> 1 Do we prevent config settings from changing after creating an >>> IW/IR? >>> >>> 2 Do we use factory or ctor to create IW/IR? >>> >>> On #1, we are technically taking something away. Are we sure no users >>> find the freedom to change IW settings mid-stream (ramBufferSizeMB, >>> mergeFactor) important? >>> >> Some of these are important I think - esp changing merge factor or the >> max segment size. >> > The question is - whether anybody's going to change > mergefactor/maxsegment size often enough he can't recreate IW without > dire performance penalties? > > >> Seems like everything that should be fixed at construction time >> (simple params at least) can be passed in the config object, and >> everything else can remain setters on the IndexWriter. Of course >> things like max segment size have been factored out into the merge >> policies... but you get the idea. >> >> -Yonik >> http://www.lucidimagination.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: java-dev-h...@lucene.apache.org >> >> >> > > > > -- - Mark http://www.lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
