[ 
https://issues.apache.org/jira/browse/LUCENE-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763580#action_12763580
 ] 

Robert Muir commented on LUCENE-1951:
-------------------------------------

Michael, cool. The bw_compat patch is still valid with these changes.

I will mention one concern, just for the record (you can tell me if it is an 
issue).

These tests test that for example, a WildcardQuery with SCORING_REWRITE 
rewrites to a TermQuery, which is correct, but now its a bit wierd how this 
happens.

SingleTermEnum -> MultiTermQuery -> BooleanQuery with one term -> TermQuery.

I couldnt think of a better way to test the correct behavior, but it is testing 
a bit more than just what happens in WildcardQuery...


> wildcardquery rewrite improvements
> ----------------------------------
>
>                 Key: LUCENE-1951
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1951
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Query/Scoring
>            Reporter: Robert Muir
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-1951.patch, LUCENE-1951.patch, 
> LUCENE-1951_bwcompatbranch.patch
>
>
> wildcardquery has logic to rewrite to termquery if there is no wildcard 
> character, but
> * it needs to pass along the boost if it does this
> * if the user asked for a 'constant score' rewriteMethod, it should rewrite 
> to a constant score query for consistency.
> additionally, if the query is really a prefixquery, it would be nice to 
> rewrite to prefix query.
> both will enumerate the same number of terms, but prefixquery has a simpler 
> comparison function.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to