[ 
https://issues.apache.org/jira/browse/LUCENE-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764563#action_12764563
 ] 

Michael Busch commented on LUCENE-1960:
---------------------------------------

I created an index with some compressed binary and String fields with 2.4 and 
verified that it gets decompressed correctly. The test fails currently on trunk 
(as expected) and passes with the latest patch.

However, there's one issue here: the compressed field gets silently 
uncompressed during merge, *only* if in the less efficient merge mode that 
doesn't use FieldsReader#rawDocs() and FieldsWriter#addRawDocuments(). So now 
this doesn't sound like a great solution that we sometimes uncompress the 
fields automatically and sometimes don't. 

I think we have three options:
1. Change FieldsWriter#addRawDocuments() to uncompress on-the-fly
2. Revert the FieldForMerge changes too and never uncompress automatically 
during merge
3. Make it possible for the user to uncompress fields with CompressionTools, no 
matter which UTF format the data was stored with

I don't really want to do 1., because it will have a performance impact for all 
fields (you have to look at the field bits even in raw merge mode). With 2. we 
will have to keep most of the compress/uncompress code in Lucene until 4.0, 
we'll just not make it possible anymore to add Store.COMPRESS fields with 3.0 
(that's already how trunk is). For 3. we'd have to add a deprecated 
isCompressed() method that the user can call.

> Remove deprecated Field.Store.COMPRESS
> --------------------------------------
>
>                 Key: LUCENE-1960
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1960
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: lucene-1960-1.patch, lucene-1960.patch
>
>
> Also remove FieldForMerge and related code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to