bq. One trivial thing that could be improved is to perhaps move all of the methods to the top of the class?
+1 - I think Mike and silently fought on that one once in the patches :) Though I don't know how conscious it was. I prefer the methods at the top myself. Yonik Seeley wrote: > On Tue, Oct 20, 2009 at 9:31 AM, Uwe Schindler <u...@thetaphi.de> wrote: > >> It is not bad, only harder to understand (for some people). >> > > The Javadoc is much improved since I made the switch. > > Right now, if I go and browse FieldComparator, I'm immediately hit > with inner classes... and it takes time to find the actual methods one > must override to create their own FieldComparator, and that make the > class seem more complex at first blush (but maybe that's just me > too...) > > > -Yonik > http://www.lucidimagination.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-dev-h...@lucene.apache.org > > -- - Mark http://www.lucidimagination.com --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
