[ 
https://issues.apache.org/jira/browse/LUCENE-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769406#action_12769406
 ] 

Uwe Schindler commented on LUCENE-2002:
---------------------------------------

A mega patch, one thing:

The highlighter testcase uses a separate constant for the version. My idea was 
to iterate over all version constants and run the test several times to test 
all combinations.

So the QueryParser ctors should also use the TEST_VERSION constant, so that it 
can be easily updated to do the testing for various versions.

> Add oal.util.Version ctor to QueryParser
> ----------------------------------------
>
>                 Key: LUCENE-2002
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2002
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 2.9, 3.0
>            Reporter: Uwe Schindler
>            Assignee: Michael McCandless
>             Fix For: 2.9.1
>
>         Attachments: LUCENE-2002-29.patch, LUCENE-2002-29.patch, 
> LUCENE-2002-29.patch, LUCENE-2002.patch
>
>
> This is a followup of LUCENE-1987:
> If somebody uses StandardAnalyzer with Version.LUCENE_CURRENT and then uses 
> QueryParser, phrase queries will not work, because the StopFilter enables 
> position Increments for stop words, but QueryParser ignores them per default. 
> The user has to explicitely enable them.
> This issue would add a ctor taking the Version constant and automatically 
> enable this setting. The same applies to the contrib queryparser. Eventually 
> also StopAnalyzer should add this version ctor.
> To be able to remove the default ctor for 3.0 (to remove a possible trap for 
> users of QueryParser), it must be deprecated and the new one also added to 
> 2.9.1.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to